Closures Best Practices

How to Use This List

• Review callback-heavy code (iterators, threads, async).
• Prefer minimal capture and clear move intent.

A - Capture Discipline

• Capture minimally - prefer references for short closures. Less move churn.
• Use move only when ownership or thread spawn requires it. Document why.
• Clone before move if both parent and child need data. Arc for shared.
• Avoid capturing large structs by move. Capture Arc or indices.
• Prefer impl Fn in generic APIs over Box<dyn Fn> when possible. Zero-cost.

B - Traits and Bounds

• Use loosest closure trait that works (Fn > FnMut > FnOnce). Flexible callers.
• Thread bounds: FnOnce + Send + 'static. No stack borrows.
• Do not hold RefCell across thread boundary. Use Mutex.
• Return impl Fn for unique closure types. Box<dyn Fn> for heterogeneity.
• Name non-trivial closures via variables. Readability in long chains.

C - Iterators

• Keep adapter chains readable (<= 5 steps) or extract functions. Maintenance.
• Avoid clone in map without need. Borrow with filter on references.
• Use filter_map and fold idioms. Fewer passes.
• Heed needless_collect clippy lint. Performance smell.
• Use rayon only for CPU-bound parallel. Not I/O.

D - Debugging

• If closure fails to compile, check move vs borrow spans. Classic errors.
• Explicit types on closure params when inference confuses. API boundaries.
• Test HOFs with simple closure doubles. Behavior verification.
• Document closure thread-safety in public APIs. Send/Sync expectations.
• Avoid recursive untyped closures. Use named fn.

FAQs

Related

• Closures Basics
• move Closures
• Collections & Iterators Best Practices
• Smart Pointers Best Practices

Stack versions: This page was written for Rust 1.97.0 (edition 2024), Tokio 1.x, Axum 0.8, serde 1.0, sqlx 0.8, clap 4, and Polars 0.46+.